[Freeciv-Dev] Re: [PATCH] Unit movement

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Jan 13, 2001 at 02:50:17AM +0100, Thue wrote:
> really hate copying it. We have the capstrings for ensuring compatability 
> across versions.
> 
> Oh, and please conform to freeciv coding style. ie indentation, and an if 

I made a new patch which does have:
 - a result.h and result.c (missed last time)
 - proper indentation
 - capstring
 - update to Makefile.am
 - profile support on the client side (since there are currently no
   users of this code it won't produce anything useful)

> > Currently the result codes are a bit unsorted. It may be better to
> > organize them hierarchical. The reporting of the result code can be
> > merged with text messages. I remember a discussion about client side
> > message generation. What was the result?
> 
> I personally liked the idea very much and is still waiting for someone to 
> show me the implementation.

There also was the idea to put the result into unit_info an send this
every time. I thing it isn't better then an extra result packet. The
thread at <http://arch.freeciv.org/freeciv-dev-200008/msg00233.html>
is quite interresting.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Windows: From the people who brought you edlin...

unit_move_result-2.diff
Description: Text document