[Freeciv-Dev] Re: [PATCH] Unit movement

[ccrayne@xxxxxxxxxxx]

In <20010113013221.A28912@xxxxxxxxxxxxxxxxxxxxxxx>, on 01/13/01 
   at 01:32 AM, Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> said:

:The other introduces a feedback mechanism. Currently there is no easy way
:on the client side to get the result of an operation carried out by the
:server.

As someone who is actively developing an AI client, I agree that there are
areas in which my task would be made easier if there were more feedback.
However -- in its current form -- your patch does not help me at all.

The most serious problem is that the client has no way of associating your
results packet with any specific event. Even if the client serializes its
requests to the server [which should NOT be required], at the time that
the client sends a unit move request, there may already be several
messages from the server queued for delivery to the client. To be useful,
the results packet must at least identify the id of the unit to which the
result code applies.

In addition, your patch unnecessarily increases network traffic, because
there is already a feedback mechanism in place for all successful move
requests, as well as for many failed ones. If the request is successful,
the server confirms the request by sending a unit information packet. If
not, things get a bit complicated, as there may or may not be a message,
and if there is a message, it may or may not have an event code.

What would really help me, and which would take advantage of the research
you have already done, would be to add the result code to the unit
information packet, and to ensure that it is sent in all cases.  

Best,
        -- Chuck Crayne
-----------------------------------------------------------
ccrayne@xxxxxxxxxxx
-----------------------------------------------------------