[Freeciv-Dev] Re: [PATCH] Unit movement

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Jan 13, 2001 at 03:25:55PM +0100, Thue wrote:
> > > Dry-run is a bad idea, IMO. When doing AI calculations you need to test
> > > lots of moves (just imagine finding a goto route), and asking the server
> > > over a slow internet connection per consideration is not an option. Just
> > > copy the 50 lines of code that do the check, dammit! :) Maybe put it into
> > > common if you
> >
> > The conditions are unfortunately wide spread
> > (unithand:handle_move_unit,unithand:handle_unit_enter_hut,
> > unithand:handle_unit_move_request,
> > unithand:handle_unit_establish_trade, unittools:can_unit_move_to_tile,
> > unittools:try_move_unit, unittools:do_airline,
> > unittools:move_unit). These methods consists of 585 lines in the
> > unpachted version. 3/4 of these lines where checks (=438 lines).
> 
> I think you only need the code in can_unit_move_to_tile().

Yes I think the error conditions from can_unit_move_to_tile would be
on top in a profile.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Your mail could not be delivered to the following Address:
  VTCMC.VTLPR@xxxxxxxxxxxxx        ** Unassigned error message **"