[Freeciv-Dev] Re: Patch: generalized granary size (PR#635)

[Thue <thue@xxxxxxx>]

On Sunday 24 December 2000 15:32, mike_jing@xxxxxxxxx wrote:
> Thue <thue@xxxxxxx> wrote:
> >Well, looking in the Changelog I can see that on May 24 the way to
> >calculate the foodbox width changed, but the food_weighting() function was
> >not updated.  So assuming it to be wrong is not a bad guess.
>
> Oh I totally agree.  It's a very good guess as a matter of fact.
>
> >It is also IMO generally bad karma to assume an uncommented function
> >that doesn't make sense to you to be perfect and therefore refuse to
> >follow your own good sense. With the amount of legacy code the AI contains
> >we will then never get anywhere. But you should of course test it in an
> >actual game before commiting.
>
> It is just that I know next to nothing about the AI code, and I am not
> going to touch it until I am sure what I am doing.   So I simply put in a
> reminder to come back and fix it later.  Something has to be done about the
> AI code sooner or later.  I am just not in a position to make changes to it
> just yet.  Of course, if anyone who knows better would like to start doing
> that, I would be very happy about it.
>
> For the moment, I don't think it's too much of a problem because these two
> patches are meant to help fix the ICS problem in multiplayer, where the AI
> palys a smaller role and is never a serious threat to experienced players
> anyway.  It will be fixed, when we finally get to it.
>
> Mike

If you want that ICS fix to get into the default ruleset the AI better be 
updated to understand it. Also, patching freeciv in a way that will get the 
AI even more out if sync is generelly not very attractive.

-Thue