[Freeciv-Dev] Re: Patch: generalized granary size (PR#635)

[Thue <thue@xxxxxxx>]

On Sunday 24 December 2000 04:32, mike_jing@xxxxxxxxx wrote:
> >So in a city of size 1 food has a value of 57, while in a city of size 2,
> >whire it takes 50% more to make the city grow, the value of
> >food is only 2/3*57 = 38. Then you would expect the next value to be
> > 3/4*38 = 28.5, but apperantly the author of this code miscalculated
> >(used 2/3 instead)...
>
> It doesn't sound unreasonable.  Of course, one can't be sure without some
> kind of testing or unless the author suddenly reappears.

Well, looking in the Changelog I can see that on May 24 the way to calculate 
the foodbox width changed, but the food_weighting() function was not updated. 
So assuming it to be wrong is not a bad guess.
It is also IMO generally bad karma to assume an uncommented function that 
doesn't make sense to you to be perfect and therefore refuse to follow your 
own good sense. With the amount of legacy code the AI contains we will then 
never get anywhere. But you should of course test it in an actual game before 
commiting.

-Thue