[Freeciv-Dev] Re: generalized improvemants (PR#243)

[蔡恆華 <iquin@xxxxxxxxxx>]

Is Make_Content_Mil meant for Police/Sufferage? (they Make_Content in the patch)
Would Spy_Resistant obsoletes sabotage? (btw: range = building is a great idea)
effect.cond_eff might lead to endless recursion.
Client might not be able to report production of Prod_To_Gold percent.

Future Enhancements:
Might want to add effect.aff_unit = { "None", "Air", "Heli", "Land", "Misl", 
"Sea" }
for _Defend, _Move, _No_Lose_Pop, _Recover, _Repair, _Vet_Combat and _Veteran.
Reveal_Cities and Reveal_Map can be combined to depend on AMOUNT.
Use #include civ2/buildings.ruleset in default/buildings.ruleset
IMHO, all the Upgrade_Units are too powerful.

Regards,
I.Q.
______________________________________________
FREE Personalized Email at Mail.com
Sign up at http://www.mail.com/?sr=signup