[Freeciv-Dev] Re: New Rapture_size in 1.9.0 (PR#194)

["Mike Jing" <miky40@xxxxxxxxxxx>]

Thanks, Jeff.  I see you have been there already.  :)  Somehow I missed that 
message buried in a discussion of translation when I was browsing the list 
archives.
> From: Jeff Mallatt <jjm@xxxxxxxxxxxx>
>
> I think it'd be nice to rationalize this.  Perhaps we could change
> rapture_size to be the size at which a city goes into rapture (and
> rapture_size=255 would naturally signal no rapture).  This value >would be 
> used in all three places (or, implicitly from all three >places via a 
> single function).  Then, to signal that rapture causes >a city to "rapid 
> grow" we could add a new flag "RaptureCityGrowth".
My sentiment exactly. Separating "rapture_size" and "RaptureCityGrowth" is 
the way to go.  Then we can let city_celebrating() to determine rapture in 
all cases, and also check the "RaptureCityGrowth" tag when deciding whether 
rapid growth is allowed.  And maybe set rapture_size=255 for Anarchy.
If there is no objection, I am going to go ahead and try to implement this.  
Please send in any further comments and suggestions.
Mike Jing

______________________________________________________
Get Your Private, Free Email at http://www.hotmail.com