[Freeciv-Dev] Re: New Rapture_size in 1.9.0 (PR#194)

["Mike Jing" <miky40@xxxxxxxxxxx>]

After looking at the code more carefully, I found that the solution to this 
problem is not as simple as I first thought.  The problem is that a 
rapture_size of zero (0) is used to indicate that a city cannot grow simply 
by celebrating, i.e. being in a state of rapture, because it's not under a 
republic or democracy.  In this case, the city can still celebrate (be in a 
state of rapture) if it is "happy" and big enough, and it gets all the other 
benifits of celebration (rapture).  However, then there is no way to tell if 
it's big enough because rapture_size is set to zero!  It seems to me that we 
should have a separate indicator for being able to grow by celebrating, 
because that's not the only meaning of "rapture".  Rapture (celebration) is 
possible under all forms of goverenment, thus rapture_size should never be 
zero.  We have to resolve this issue before we can get rid of the hardwired 
numbers.
Please comment.

Mike Jing

______________________________________________________
Get Your Private, Free Email at http://www.hotmail.com