[Freeciv-Dev] Re: New Rapture_size in 1.9.0 (PR#194)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 1999/12/18 11:07 , Mike Jing wrote:
>Please comment.

I posted the following to freeciv-dev a while ago:

>At 1999/11/11 21:07 , David Pfitzner wrote:
>>adjustable in governments.ruleset file.  Could either have an 
>>extra field (or use rapture_size=-1?) to signal no rapture,
>>or just check whether it has no effect.
>
>Currently, rapture_size is used only for the "rapid growth" aspect of
>Rapture, in update_city_activity() in cityturn.c.  There is a separate
>function, city_celebrating() in city.c, that determines "rapture" for
>food/shields/trade and for the City Report dialog.  And, there's a third
>place (again, in update_city_activity()) where "rapture" is computed for
>the "we love" messages.
>
>Unfortunately, they all use different algorithms!  The last two I mentioned
>use burned-in city size constants, which are different from each other and
>different than the rapture_size value.
>
>I think it'd be nice to rationalize this.  Perhaps we could change
>rapture_size to be the size at which a city goes into rapture (and
>rapture_size=255 would naturally signal no rapture).  This value would be
>used in all three places (or, implicitly from all three places via a single
>function).  Then, to signal that rapture causes a city to "rapid grow" we
>could add a new flag "RaptureCityGrowth".
>
>Opinions?  Also, have I missed any other rapture stuff in the code?

jjm