[Freeciv-Dev] Re: Help->ZOC in 1.8.3beta (PR#142)

[Reinier Post <rp@xxxxxxxxxx>]

On Tue, Oct 05, 1999 at 12:24:56AM +1000, David Pfitzner wrote:
> #&%-listar...
> 
> (Original also CC-ed to bugs@xxxxxxxxxxxxxxxxxxx)
> 
> Reinier Post wrote:
> 
> > Selecting any [listar-munge]help item will cause the crash.
> > The problem is an attempt to create tiles with unit pictures;
> > the units aren't known yet.
> > 
> > A fix against the Oct 2 snapshot is attached.  It appears to be
> > a clean solution, but someone with more than 10 secs experience
> > with the GTK code may wish to look it over.
> 
> Ah thanks, now I can reproduce it; the real problem comes from:
> 
>   if(!use_solid_color_behind_units)  {
>     struct Sprite *flag=get_nation_by_plr(game.player_ptr)->flag_sprite;
> 
> and unfortunately I happened to have use_solid_colors set in my 
> .civclient due to some other unrelated testing.  

This leaves me puzzled.  My patch *did* fix the problem, but clearly,
a different one.  I also wonder how it made it past the compiler,
returning without a value in a function that required one.

An update is attached, in case it's still useful.

-- 
Reinier

oct3+gtkhelpfix.diff-Nurd
Description: Text document