[Freeciv-Dev] Re: Help->ZOC in 1.8.3beta (PR#142)

[Reinier Post <rp@xxxxxxxxxx>]

> > > when accessing Help->ZOC in 1.8.3beta during pre-game freeciv client
> > > closes and writes:
> > > 
> > > 0: get_nation_by_plr before nations setup
> > I cannot reproduce this, neither for 1.8.3 nor for current cvs.
> > Can you reproduce it?  If so, can you give precise instructions
> yes.
> 
> run a local server of freeciv(it can be a non-local one as well)
> 
> connect to the server using civclient(from 1.8.3, GTK version), DO NOT
> START THE GAME ON THE SERVER and go to Help->ZOC.

Selecting any help item will cause the crash.
The problem is an attempt to create tiles with unit pictures;
the units aren't known yet.

A fix against the Oct 2 snapshot is attached.  It appears to be
a clean solution, but someone with more than 10 secs experience
with the GTK code may wish to look it over.

Incidentally, it would be better if the rulesets were read
at the time they are specified (on startup and whenever the
server variables change).  That way, any errors can be caught
before the game is started.

-- 
Reinier

oct3+gtkhelpfix.diff-Nurd
Description: Text document