Re: [Freeciv-Dev] [2 x Patch] struct government + unit upkeep

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Sune Kirkeby wrote:
> 
> Firstly is the "struct government" patch, which joins all the
> information about a government in one struct, and creates an
> array of these (hardcoded).

Sounds good.  Should be an easy step to fill this struct array 
from a "governments" ruleset file.  Someone posted before the 
ruler titles used by Civ2; check the archives.

> Second is the unit upkeep patch, which removes the hardcoded
> unit upkeep costs, and replaces them with values from four new
> fields in units.rulesets. (The fourth being a recently suggested
> suggested gold upkeep cost).

Sounds fine to me.

For the units change, this probably requires an incompatible ("+")
tag in the capabilities string, and the new info should be sent
to clients.

-- David

ps, no C++ style comments please.