[freeciv-ai] Re: (PR#2477) Improved Auto-Explore

["Cameron Morland via RT" <rt@xxxxxxxxxxxxxx>]

On Thu, Dec 19, 2002 at 04:08:14PM -0800, Gregory Berkolaiko via RT wrote:
> Cameron,
> 
> Quoting Gregory Berkolaiko via RT <rt@xxxxxxxxxxxxxx>:
> 
> > Quoting Cameron Morland via RT <rt@xxxxxxxxxxxxxx>:
> > 
> > > On Thu, Dec 19, 2002 at 03:15:16PM +0000, Gregory Berkolaiko wrote:
> > > > or different?  Can't base score be just added to both land_ and ocean_ 
> > > > scores?
> > > 
> > 
> > Understood.  You still haven't answered my second question though.

Uh... I guess. Your modifications look fine.

> Well, I just changed the code without waiting for the answer.  Attached is my
> result.  Most notable changes:
> 
> 1. I decided that distance 3 from a friendly city is not good enough.  We want
> our own, we don't give a damn about our allies.

OK, I agree.

> 2. As you can see I prefer ( ? : ) operator to if-else.

It's fine with me, I prefer it too under some circumstances.

> 3. Instead of pow I re-use amortize.  The multiplier of 5 reproduces your 0.8
> weighting: (23/24)^5 = 0.81.  Amortize is better because it's (a) faster and 
> (b)
> can be made even faster.

Sure. 0.8 was noticeably better than 0.9, but I couldn't see any difference
by adjusting it slighty.

> 4. Conerted consts to defines and some other style issues.

I'm more fond of consts, but it doesn't matter.

> Please feel free to criticize :(
> 
> 
> All others: I intend to commit this patch soon (when Cameron blesses my 
> changes,
> basically).  So comment now or...

ssh from a windows box over a modem. Ugh.

Your mods appear to be fine, and I assume that it compiles. It shouldn't behave
significantly differently.

-- 
+-----------------------------------------------------------------
| PGP http://www.eng.uwaterloo.ca/student/cjmorlan/public-key.pgp
| Cameron Morland             ----             Cameron@xxxxxxxxxx
|
| Contempt, rather than celebration, is the proper response
| to advertising and the system that makes it possible.
|     --Neil Postman
+-----------------------------------------------------------------

pgpR9yezpR29j.pgp
Description: PGP signature