Complete.Org: Mailing Lists: Archives: freeciv-ai: December 2002:
[freeciv-ai] (PR#2477) Improved Auto-Explore

[freeciv-ai] (PR#2477) Improved Auto-Explore

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: cameron@xxxxxxxxxx
Cc: freeciv-ai@xxxxxxxxxxx
Subject: [freeciv-ai] (PR#2477) Improved Auto-Explore
From: "Guest via RT" <rt@xxxxxxxxxxxxxx>
Date: Tue, 3 Dec 2002 05:19:38 -0800
Reply-to: rt@xxxxxxxxxxxxxx

[rfalke - Tue Dec  3 07:35:06 2002]:

> Please remove some unneeded ().

OK, I think I removed them all. I like to put in "unneeded ()" because I
once programmed a DSP with a programming language that was almost
indistinguishable from C; the only difference was '||' bound more
closely than '&&'. Since then I've been a bit free with the brackets.
Here I left some in to prevent a warning from gcc.

> Can't 0x80 and co be replaced with an enum?

Probably. I want it to return a "fuzzy" value, so code that uses it
could make decisions based on how certain they are that the value is
ocean. I'm not sure how to do this using enum. How about

#define OCEAN_CERTAIN_IS  0x80
#define OCEAN_UNKNOWN     0x40
#define OCEAN_CERTAIN_NOT 0x00

? I you think that's a good idea I'll add it in the next revision.

Attachment: explorer4.diff
Description: explorer4.diff

[Prev in Thread] Current Thread [Next in Thread]