Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2006:
[Freeciv-Dev] (PR#15636) Editor: Change city from within city dialog
Home

[Freeciv-Dev] (PR#15636) Editor: Change city from within city dialog

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: per@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#15636) Editor: Change city from within city dialog
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 20 Feb 2006 16:53:40 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15636 >

> [jdorje - Mon Feb 20 18:34:01 2006]:

> However I am very wary of embedding edit commands into the core server
> code, as you seem to have done by overloading all of the city-changing
> packets to allow unlimited changes when in edit mode.  I think it will
> be safer in the long run to have the server editor code be in a separate
> file, making things more modular and decreasing complexity of the
> handling packets - which are the second-most complex part of freeciv
> (after end-of-turn).

To point out a more concrete problem, editor packets have to be
handle-per-conn so that global observers can edit.  This is currently
not the case for most regular game packets, and changing that would
increase the complexity even more.

-jason




[Prev in Thread] Current Thread [Next in Thread]