[Freeciv-Dev] (PR#14652) Patch proposal: resources cleanup
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14652 >
OK, but back to the core issue here...
I'm not entirely happy with the renaming. I don't see why
"modification" is any better than "special". Both are bad.
The resources.diff patch however looks pretty good. You should review
the style guide, there are a few places that don't conform (not a big
deal though). If you can provide just this patch, without the rename, I
*think* it can be committed.
Someone else needs to review the ruleset bits though.
-jason
- [Freeciv-Dev] Re: (PR#14652) Patch proposal: resources cleanup, Jérôme Plût, 2005/12/01
- [Freeciv-Dev] Re: (PR#14652) Patch proposal: resources cleanup, Jason Short, 2005/12/01
- [Freeciv-Dev] (PR#14652) Patch proposal: resources cleanup,
Jason Short <=
- [Freeciv-Dev] Re: (PR#14652) Patch proposal: resources cleanup, Jerome Plut, 2005/12/05
- [Freeciv-Dev] Re: (PR#14652) Patch proposal: resources cleanup, Jason Short, 2005/12/07
- [Freeciv-Dev] Re: (PR#14652) Patch proposal: resources cleanup, Jerome Plut, 2005/12/08
- [Freeciv-Dev] (PR#14652) Patch proposal: resources cleanup, Jason Short, 2005/12/10
- [Freeciv-Dev] Re: (PR#14652) Patch proposal: resources cleanup, Jerome Plut, 2005/12/12
|
|