Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2005:
[Freeciv-Dev] (PR#14652) Patch proposal: resources cleanup
Home

[Freeciv-Dev] (PR#14652) Patch proposal: resources cleanup

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jerome.Plut@xxxxxx
Subject: [Freeciv-Dev] (PR#14652) Patch proposal: resources cleanup
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 2 Dec 2005 18:44:04 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14652 >

OK, but back to the core issue here...

I'm not entirely happy with the renaming.  I don't see why
"modification" is any better than "special".  Both are bad.

The resources.diff patch however looks pretty good.  You should review
the style guide, there are a few places that don't conform (not a big
deal though).  If you can provide just this patch, without the rename, I
*think* it can be committed.

Someone else needs to review the ruleset bits though.

-jason




[Prev in Thread] Current Thread [Next in Thread]