[Freeciv-Dev] Re: (PR#13730) 12+1 nations patch

["Daniel Markstedt" <himasaram@xxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13730 >


On 2005-09-04, at 23.03, Christian Knoke wrote:

>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13730 >
>
> On Sun, Sep 04, 2005 at 10:28:11AM -0700, Daniel Markstedt wrote:
>>
>> Attaching a new patch that will fit the latest CVS. Hoping for the
>> best. :-)
>
> Hi Daniel,
>
> I appreciate your efforts to improve the Freeciv nations, but I 
> suggest to
> put just 1 nation into 1 patch and not gzip it, because it is so much 
> easier
> to review them, avoid bugs, and filter them, good ones in, bad ones 
> wait to
> improve.
>
> And please put the nation name in the subject line..
>
> BTW isn't it possible to send patches and still use the data mailing 
> list
> with RT?
>
> Christian
>
>

Don't worry I won't make this mistake again. I originally just wanted 
to contribute one nation (Sami) but it quickly got out of hand and this 
bloated patch is the result. I don't think there are any bugs left 
though. I'm running a game with these additional nations and have no 
problems.

Daniel