Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2005:
[Freeciv-Dev] (PR#13730) 12+1 nations patch
Home

[Freeciv-Dev] (PR#13730) 12+1 nations patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: himasaram@xxxxxxxx
Subject: [Freeciv-Dev] (PR#13730) 12+1 nations patch
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 3 Sep 2005 21:19:32 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13730 >

I have no objection to committing a patch that adds a bunch of nations
at once.  However larger patches do get out-of-date faster and it takes
more work to update them.  This patch is already quite out-of-date (from
the other updates we've made to nations no doubt).

Another quick comment on style:

legend=_("Australian Aborigines is a collective term for the original \
inhabitants of the Australian continent. Aborigines from different parts
of \
Australia refer to themselves with different names, for example Koori, \
Yamaji, Nunga, Murri and so on.")

in this text please put the \ before the space not after it...so the
space goes at the beginning of the line, and acts as indentation.

Aside from this I haven't closely examined the nations or flags (I may
just skim them before committing so if anyone feels strongly about
nations you should give the patch your own review).

-jason




[Prev in Thread] Current Thread [Next in Thread]