[Freeciv-Dev] Re: (PR#13745) savegame crash

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13745 >

Per I. Mathisen wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13745 >
> 
> On Tue, 23 Aug 2005, Mateusz Stefek wrote:
> 
>>This is the fix.
>>Commiting immediately.
> 
> I committed another fix which should also work, but that is ok.
> 
> Should perhaps consider a similar fix as yours for 2.1? Not that anything
> is broken there (yet), but keeping around target_government in an invalid
> state is perhaps a ticking bug..

No, 2.1 is fine.  target_government is allowed to be NULL (just like 
making it G_MAGIC in 2.0) and savegame.c and other callers should check 
for this if needed.

-jason