Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2005:
[Freeciv-Dev] Re: (PR#13745) savegame crash
Home

[Freeciv-Dev] Re: (PR#13745) savegame crash

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#13745) savegame crash
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Tue, 23 Aug 2005 01:28:00 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13745 >

On Tue, 23 Aug 2005, Mateusz Stefek wrote:
> Actually the real problem is in common/player.c - before PR#13740 and
> PR#13723 it was zero and this was ok. Now it is set to G_MAGIC and
> nothing changesthat later. The game crashes always, not only when
> barbarians are created.

Isn't the real problem that we try to save a target government when we
have no target government?

In 2.1 we have this in savegame.c:

  if (plr->target_government) {
    secfile_insert_str(file, plr->target_government->name_orig,
           "player%d.target_government_name", plrno);
  }

which makes more sense.

  - Per





[Prev in Thread] Current Thread [Next in Thread]