[Freeciv-Dev] Re: NEWS-2.03

[Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxx>]

On Thu, 28 Jul 2005, Jason Dorje Short wrote:

> Per Inge Mathisen wrote:
> >>* Fix Pyramids so they are no longer cumulative with Granary.
> >
> > I do not understand this one. How is this ensured, and why? The
> > cumulativeness of Pyramids and Granaries was deliberate last time I heard.
>
> In the development version granary gives a 50% bonus and pyramids a 25%
> bonus, which are deliberately cumulative.
>
> In 2.0 granary and pyramids each give 50% bonuses.  These are not
> supposed to be cumulative (you can't build them at the same time because
> of equiv_repl, unless you try hard) but they are.  This is a mistake
> from when the effects code was written - Vasco had originally made this
> a boolean value but I changed it to an integer, the rulesets were never
> fixed properly, and nobody noticed because of the equiv_repl entry.

Yeah. But equiv_repl is no more. Thank goodness.

It is probably a good idea to deskcheck the code at the time for more
boolean -> integer conversions in case this bug was added elsewhere.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa