Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2005:
[Freeciv-Dev] (PR#13429) Move player_research to team
Home

[Freeciv-Dev] (PR#13429) Move player_research to team

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mstefek@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#13429) Move player_research to team
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 13 Jul 2005 08:40:06 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13429 >

- You can't "assert(plr && plr->team);".  For some reason on some
systems pointers can't be treated as booleans inside assert.  So you
need "assert(plr != NULL)", etc.

- In team.c I really don't like the 

+  if (!pteam) {
+    pteam = find_empty_team();
+  }

bit.  This should never happen but if it does it will leave the game in
a wrong state I suspect.  I'd suggest changing it to an assertion.




[Prev in Thread] Current Thread [Next in Thread]