[Freeciv-Dev] Re: (PR#13429) Move player_research to team

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13429 >

Mateusz Stefek wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13429 >
> 
>>>2.  get_player_research should return NULL if the player has no team.
>>>Callers must be audited for teamless players or NULL return values.
>>
>>Why can't we assume that each players has a team?
>>An autogame with barbarians and civil war seems to work.

> 
> This patch makes sure that each player has a team. If pteam is NULL in
> team_add_player(), an empty team will be choosen.

Hmm, but each player does have a team.  If there's no team then
team_add_player is more likely not to be called rather than being called
with a NULL team.  Note that assigning a random team may not be a good
bet.  For instance savegame.c will leave teamless players without teams
(for backwards compatibility) then loop through and assign teams where
needed at the end.

-jason