[Freeciv-Dev] Re: [FreeCiv-Cvs] per: A vote needs plurality (>50% of votes) to pass....

[Thomas Müller <mail@xxxxxxxxxxx>]

Am Dienstag, 28. Juni 2005 11:04 schrieb Per Inge Mathisen:
> On Tue, 28 Jun 2005, Thomas [utf-8] Müller wrote:
> > > > A vote needs plurality (>50% of votes) to pass. it does not matter
> > > > how many turns it takes. This removes the problem of surprise votes.
> > > > Player observers cannot vote or suggest new votes; right now they can
> > > > pretend to be the controlling connection; i see no reason to grant
> > > > observer suffrage. These things have been noted by several people,
> > > > fixed first by
> > >>
> > >> this patch in PR#12604.
> > >
> > > Does this need to be ported to 2.0?
> > >
> > > -jason
> >
> > Yes.
> > With this bug, one person can vote all kind of stupid things in a game,
> > in combination with voting observers this could lead to big problems on
> > pubservers, so this patch needs to get to pubservers fast...
>
> I backported the voting-observers part of the patch. I am not sure if we
> should backport the other part (since it may need further changes to
> other parts to be fully sane).

I guess the patch already is on puserver, observers cant vote anymore, but 
they still can start votes. Pretty annoying, but not as bad as voting itself.
Maybe you should also write a check if someone is observer, when starting a 
vote.

Thomas