[Freeciv-Dev] Re: (PR#12896) Diplomat fixes

["Thomas.Strub@xxxxxxxxxxxxxxxxxxxxx" <Thomas.Strub@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12896 >

Zitat von "Per I. Mathisen" <per@xxxxxxxxxxx>:

> 
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12896 >
> 
> This patch fixes some issues reported with diplomats, but I was unable to
> find the relevant ticket(s), so I made a new one.
> 
> CHANGES:
>  - Diplomat combat calculation now more fair. Does not rely on diplchance.

Fine, should look into the code, but the old behavier was improveable.

>  - Give a message to reveal why a diplomat was caught when trying to steal
>    from a city you have stolen from before.
>  - Allow auto-success for diplomats (diplchance=100).

Ok.

>  - Limit diplchance to a minimum of 50 to restrict diplchance cheating.
>    (Players setting diplchance to some absurd low value without other
>    players noticing.)

Reducing diplchance to 1 is a needed feature against autodiplomats!
As long as there is no other feature against autodiplomats reducing diplchance
is needed.

Thomas