[Freeciv-Dev] Re: (PR#11686) unit_list_size(&ptile->units) == 0

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11686 >

Marko Lindqvist wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=11686 >
> 
> Christian Knoke wrote:
> 
>>1: 0x863a5b0 Dragoner at (33,30) Kotromanic
>>civclient: packhand.c:1992: handle_tile_info: Zusicherung
>>»unit_list_size(&ptile->units) == 0« nicht erfüllt.
> 
>   One of the possible reasons to this is move_unit() which first fogs 
> area and only then removes some submarines. I think that we should allow 
> this order of network packets and to simply remove that overzealous assert.

Any subs hidden in the fog should have been removed when the area was 
fogged (and then removed again later, maybe).

I have no strong objections to removing the assert.  The bugs it has 
caught in the past have been real bugs (like the alliance-vision bugs). 
  However it is very inefficient about catching them (lots of people's 
games assert before the bug is found).

-jason