[Freeciv-Dev] Re: (PR#10336) citymap cleanup

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10336 >

On Sat, 25 Sep 2004, Jason Short wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10336 >
> 
> >>  -          citymap[x1][y1] = citymap[x1][y1]++;
> >>  +          CITYMAP(x1, y1)++;
> >>
> >>the former is clearly not what was intended since it does nothing (I
> >>think).  I assume the latter is what was meant.
> > 
> > 
> > If this was broken, I can't see how it would work at all. Do you get
> > autogame differences? If this was a bug and you fixed it, AI would behave
> > quite differently when choosing cities.
> 
> Savegames are identical in the one autogame I ran.
> 
> I can't see where this value is ever checked.  Nobody seems to care if 
> the value is greater than 0.  But I have no idea what this value is 
> supposed to mean (there is *no* documentation for citymap that I can 
> see) so really I have no idea what is going on.
> 
> It's also possible that the two lines of code give the same results.  Is 
> the ++ evaluated after the = or before it?  I have no idea.

funnily, in either case it would produce the same result as 
        citymap[x][y]++  
:)