[Freeciv-Dev] Re: (PR#10336) citymap cleanup

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10336 >

On Sat, 25 Sep 2004, Jason Short wrote:
> >>-          citymap[x1][y1] = citymap[x1][y1]++;
> >>+          CITYMAP(x1, y1)++;
...
> I can't see wherethis value is ever checked. Nobody seems to care if
> the value is greater than 0.

ai/aisettler.c:
  140:     int reserved = citymap_read(map_x, map_y);
  191:     /* Avoid crowdedness, except for city center. */
  192:     if (sum > 0) {
  193:       sum -= MIN(reserved * GROWTH_PRIORITY, sum - 1);
  194:     }

> (there is *no* documentation for citymap that I can see)

There is some in citymap.c line 35. If there is anything else you want me
to document, let me know.

  - Per