[Freeciv-Dev] Re: (PR#10336) citymap cleanup

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10336 >

On Sat, 25 Sep 2004, Jason Short wrote:
> - Another major bug is fixed: the citymap is never initialized. It
> starts out as 0 but if you play multiple games it gets filled with
> garbage. This is a severe bug and will probably never show up in any
> tests.
...
> (Side note: is this really the way it's supposed to be?Shouldn't the
> citymap be resetat some point during the game?Shouldn't there be one
> citymap per player?Etc., etc.)

What are you talking about? citymap_turn_init() remakes the citymap every
turn.

>   -          citymap[x1][y1] = citymap[x1][y1]++;
>   +          CITYMAP(x1, y1)++;
>
> the former is clearly not what was intended since it does nothing (I
> think).  I assume the latter is what was meant.

If this was broken, I can't see how it would work at all. Do you get
autogame differences? If this was a bug and you fixed it, AI would behave
quite differently when choosing cities.

  - Per