[Freeciv-Dev] Re: (PR#10034) no contact with adjacent player

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10034 >

Marko Lindqvist wrote:

>   btw. I wonder if all things are really made in correct order in 
> civil_war() (or more accurately: this seems bug prune, small changes in 
> other parts of freeciv might easily break this.)
>   For instance, new player initialization has been going for some time 
> before 'game.nplayers++;' I don't know if it's possible to move this 
> upwards, but those function calls with what someone might consider 
> illegal player_no...

I don't know this code very well, but from your patch it looks like code 
for civil war is spread out all over the place.  Bad.

>   Second; ai_data_init(), assess_danger_player() are called in 
> split_players() - but cities and units are divided only later (original 
> player still thinks that he has all cities and units, new player has no 
> cities nor units).

Also bad.

jason