[Freeciv-Dev] (PR#2521) general effects framework

["Jason Short via RT" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://RT::WebBaseURL.not.configured:80/Ticket/Display.html?id=2521 >

OK, here is a new patch.

I went over every line of effects.[ch] and cleaned it up.

I renamed a bunch of variables.  For instance "arg" as an argument to a
function isn't very descriptive.

I finally figured out the correct name for count_targets_in_range.  It
should be count_sources_in_range!

I added lots of comments.  Particularly some explaining the groups.

I'm now satisfied with these two files, and with the patch overall.

jason

effects21.diff.bz2
Description: application/bzip