[Freeciv-Dev] (PR#2521) general effects framework

["Jason Short via RT" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://RT::WebBaseURL.not.configured:80/Ticket/Display.html?id=2521 >

Here is an update and new version of the effects patch.

In addition to the update, I made a lot of changes.

- Callers of get_xxx_bonus shouldn't treat it as a boolean.
- Renamed some eff variables and globals as effect.  Similarly eft gets
renamed as effect_type.  And in some places eff becomes effect_type...
- Removed an unused field from a packet.
- Merged get_xxx_bonus into one function (in the backend only).  Pretty
nifty.  I'd say this is the core of Vasco's design, and it should show
how it can be extensible.
- Added a new function ruleset_cache_free.  It is called from the server
only (the client just leaks data for now).
- Added some more explanatory comments.
- Updated and included the other rulesets.

jason

effects16.diff.gz
Description: Unix tar archive