[Freeciv-Dev] (PR#10048) Re: effects patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10048 >

I think it is unnecessary for the group to list the range.

- The group is linked to a list of sources (buildings).
- Each effect may optionally list a group.

Only if the effect lists the group and the group lists the effect's 
source does anything happen.  But if this does happen then we already 
know the range: it is given in the effect.


It would be possible for the group to list the effects directly (rather 
than listing the effect's source), except that effects don't have names. 
  However if each effect had an optional name, then all that would be 
needed is the group list.

Or it would be possible to drop the group list and have the effect 
simply list which group it's in.  Then the group can be assembled simply 
of all effects in the group, except that then there is no way to tell 
the order of the group (which is important since the first entry in the 
group gets precedence).

Neither of these is particularly helpful.  However I do think the range 
should be dropped from the group.

jason