Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map()
Home

[Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map()

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mburda@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map()
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 1 Sep 2004 09:19:15 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9799 >

Marcelo Burda wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9799 >
> 
> Le mer 01/09/2004 à 17:03, Jason Short a écrit :
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=9799 >
>>
>>I edited the patch a bit.  Here's the result.
>>
>>However there are two problems.
>>
>>1.  Swamps are never placed.  This is because the method of placing 
>>swamps at places where hmap < .6 * maxval means all potential swamp 
>>tiles are now underwater.  I think the method in current CVS is broken 
>>too though.
> 
> this is fixed in the next patch, i can do something now but as this
> proble apear only if landmass > 60% default is 35%!! may the best is to
> do to the next patch

It shows up if the landmass is 40% or less, which it usually is.

>>2.  Polar normalization is done after adjust_hmap is called.  It 
>>therefore breaks the linear distribution of the hmap.
> 
> yes but after renormalize_map do the inverse and anyway poles are
> avoided by generator(my code)

Couldn't we just reverse the lines?  Do the normalize before the adjust?

jason




[Prev in Thread] Current Thread [Next in Thread]