[Freeciv-Dev] Re: (PR#436) Bug: game state not totally preserved in savegames

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=436 >

Marko Lindqvist wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=436 >
> 
> Jason Short wrote:
> 
>>  In this case simply inserting
>>the units randomly will not fix this because it will be different after
>>the reload.
> 
> 
>   True, but there is two separate bugs, requiring separate fixes. One is 
> that save+load changes list order (this ticket). Another is that list is 
> in a 'well defined' order even without saving+loading. get_defender() is 
> obvious problem case, but there might be other places where iteration 
> order matters.

Yep.  If we use the "priority" method we have to hunt down such cases. 
Tedious and bug-prone.  But I'm not convinced any other method is 
possible to solve all the bugs and buglets.

And don't forget the third buglet, that server and client can 
potentially give different values even if the order is well-defined.

jason