[Freeciv-Dev] (PR#9695) mapgen error / topology 11

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9695 >

> [jshort@xxxxxxxxxxxxxx - Ven. Aoû. 13 22:25:01 2004]:
> 
> >
> 
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=9695 >
> >
> > This is the one i can't reproduce i use this file, are you sure is
> the
> > good one Marcelo
> 
> Like I said, I couldn't get the seed or randseed values.  Without
> those your chances of reproducing it are small (but with enough tries
> I'm sure we could do it).
> 
> jason
> 
there is a patch to avoid save incomplete data there.
in this place save a full game is useless to debug 
the good die is ok

Marcelo
> 
> 

diff -ruN -Xfreeciv/diff_ignore freeciv.back/server/mapgen.c 
freeciv/server/mapgen.c
--- freeciv.back/server/mapgen.c        2004-08-13 21:08:52.721694024 +0200
+++ freeciv/server/mapgen.c     2004-08-13 22:26:39.145289808 +0200
@@ -1472,15 +1472,15 @@
 {
   int x, y, k, sum;
   struct start_filter_data data;
-
+  
   if (!islands) {
     /* Isle data is already setup for generators 2, 3, and 4. */
     setup_isledata();
   }
 
-  data.count = 0;
   data.dist = MIN(40, MIN(map.xsize / 2, map.ysize / 2));
 
+  data.count = 0;
   sum = 0;
   for (k = 1; k <= map.num_continents; k++) {
     sum += islands[k].starters;
@@ -1502,16 +1502,14 @@
       freelog(LOG_DEBUG, "Adding %d,%d as starting position %d.",
              x, y, data.count);
       data.count++;
+
     } else {
       data.dist--;
       if (data.dist == 0) {
-       char filename[] = "map_core.sav";
-
-       save_game(filename);
        die(_("The server appears to have gotten into an infinite loop "
              "in the allocation of starting positions, and will abort.\n"
-             "The map has been saved into %s.\n"
-             "Please report this bug at %s."), filename, WEBSITE_URL);
+             "Maybe the numbers of players/ia is too much for this map.\n"
+             "Please report this bug at %s."), WEBSITE_URL);
       }
     }
   }