[Freeciv-Dev] (PR#8890) Patch: Removal of free city center

["Mike Jing" <miky40@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8890 >

Here is an updated patch.  I changed game.ruleset so that free city
center is still on by default, and took out the change in foodbox
increment so it's more suitable for CVS inclusion.  These ruleset
changes, along with my tweaks, are put in a separate patch for those who
want to do further testing.

Remaining issues:
1. Jason would still think the single food bonus is an ugly hack, and
indeed it is.  However, I don't see any viable alternative at the
moment, and it is certainly no more bogus than, say for example,
min_city_center_food.  We can make it a ruleset option if it makes
people feel better, but I don't know if it's really necessary.  In
addition, maybe auto-water and auto-road should be ruleset options as well. 
2. As metioned before, you can no longer auto-rearrange city workers by
clicking on the city center.  Personally I don't find it too much of a
hardship, but others may miss this functionality.
3. I don't use CMA so I don't know if this would cause any problem
there.  So anyone who uses it please test.
4. The AI may not be able to deal with it too well.  So this is
something to keep in mind when auto-settler is rewritten.

I want to emphasize once again that this is not a complete solution to
smallpox, but simply a step to remove one of its more glaring
advantages.  I think this implementation works rather well, if not at
all elegant.  I do not intend it to be accepted as the default, as I
don't expect people to give up smallpox.  So this won't affact default
gameplay, and I hope it doesn't add too much cruft to the code base.

Mike Jing