Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2004:
[Freeciv-Dev] (PR#9038) double check for odd ysize
Home

[Freeciv-Dev] (PR#9038) double check for odd ysize

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#9038) double check for odd ysize
From: "Marcelo Burda" <mburda@xxxxxxxxx>
Date: Wed, 30 Jun 2004 13:55:46 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9038 >

> [jdorje - Dim. Jun. 20 04:25:58 2004]: 
>  
> In srv_main.c there is code like: 
>  
>    if ((topo_has_flag(TF_ISO) || topo_has_flag(TF_HEX)) &&  
> topo_has_flag(TF_WRAPY) 
>        && (map.ysize % 2 == 1)) { 
>      /* To wrap north-south an iso-map must have even Y dimension.  
> Since the 
>       * X dimension is compressed this isn't an issue for east-west 
>       * wrapping. */ 
>      /* TODO: if an init_topology() function is written this should 
go  
> inside 
>       * it. */ 
>      map.ysize++; 
>    } 
>  
> but this is redundant since ysize is set inside init_topology and is  
> guaranteed to be valid.  I think it should be removed. 
>  
> Marcelo? 
>  
> -jason 
>  
>  
i thin that too. this is the responsability of init code to do that. 
this check can be cleaned. 
>  
 


[Prev in Thread] Current Thread [Next in Thread]