Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2004:
[Freeciv-Dev] Re: (PR#9123) Save unit types by names
Home

[Freeciv-Dev] Re: (PR#9123) Save unit types by names

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#9123) Save unit types by names
From: "Mateusz Stefek" <mstefek@xxxxxxxxx>
Date: Sun, 27 Jun 2004 12:20:00 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9123 >

On 2004-06-27 18:56:53, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9123 >
> 
> > [mstefek@xxxxxxxxx - Sun Jun 27 08:05:06 2004]:
> >
> > After adding worker unit Diplomats from old savegames became  
> nukes!!
> > And generally all units are read wrong.
> >
> > To avoid such problems in the future I wrote a patch which saves
> unit
> > types by name. Old field "type" is still supported for backward
> > compatibility.
> 
> Clever, although complicated.
> 
> But why do you have to move the attribute loading code around?
> 
> jason
>
diff -u isn't very clever. I didn't change attribute loading code. I  
just created new function 'player_load_units' and moved unit loading  
code there. player_load_units is longer than attribute loading code so  
diff thought it was the best way to produce patch.
--
mateusz





[Prev in Thread] Current Thread [Next in Thread]