[Freeciv-Dev] Re: (PR#7322) Four small features requests

["Josh Cogliati" <jjc@xxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7322 >

On Sun, May 23, 2004 at 08:47:49AM -0700, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7322 >
> 
> Josh Cogliati wrote:
> 
> >>>>+ game.players[j].embassy |= (1 << pplayer->player_no);
> >>
> >>Isn't there a function for this.
> > 
> > Not really.  You are probably thinking of establish_embassy in diplhand.c
> > However, establish_embassy also sends out packets notifying the players of 
> > the new embassy.  Since generate_ai_players is called before all 
> > the game starts this triggers an assertion.  
> > 
> > So calling establish_embassy doesn't work, and even if it did, it would 
> > cause extra packets to be sent.
> > 
> > The new version changes to using players_iterate.  Other than that, it
> > is the same as the previous version.
> 
> It should use BV_SET.  If the value isn't a BV_DEFINE...it should be...
> 
> But perhaps this is beyond the scope of the patch.

Probably.  Among other things, this will change the savegame format 
and the network protocol, if I am understanding what you are requesting
and the code.

-- 
Josh Cogliati