[Freeciv-Dev] (PR#8482) Re: (PR#8819) GTK2 production dialog: ugly as sin.

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8482 >

Vasco Alexandre da Silva Costa wrote:

>>create_overlay_unit() seems to be the culprit.
>>If you're going to allow the removal of the task icons, then allow the 
>>removal of the horrid color background
> 
> 
> This all started because someone thought it would be a good idea to
> distinguish land vs sea units. Eh.

I like the color background.  I even suggested some "enhancements" (to 
distinguish military versus civilian units).

> Please refer to #8482 for more discussion and a patch for this by Daniel
> Speyer. I am merging this ticket with that.

The flags should be removed.

> The code to make it work with any tileset and handle ruleset re-sends is
> not as trivial as one may think.

See tileset_changed().

jason