[Freeciv-Dev] (PR#8819) GTK2 production dialog: ugly as sin.

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8819 >

> [kauf - Sun May 23 19:43:57 2004]:
> 
> http://www.freeciv.org/~kauf/production_dialog.png
> 
> wow. that's ugly.

Yeah, but it works for 100% of the cases required, which was not the
case of the previous alternatives.

> create_overlay_unit() seems to be the culprit.
> If you're going to allow the removal of the task icons, then allow the 
> removal of the horrid color background

This all started because someone thought it would be a good idea to
distinguish land vs sea units. Eh.

> and flags. I also note that the
> sizing proportions make this blech too.
> 
> I would suggest that it default to no background color and no flag.
> UNIT_TILE_HEIGHT and UNIT_TILE_WIDTH isn't going to work either.

Please refer to #8482 for more discussion and a patch for this by Daniel
Speyer. I am merging this ticket with that.

The code to make it work with any tileset and handle ruleset re-sends is
not as trivial as one may think.