Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] (PR#8796) bug(s) in city_increase_size
Home

[Freeciv-Dev] (PR#8796) bug(s) in city_increase_size

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#8796) bug(s) in city_increase_size
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 23 May 2004 10:01:42 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8796 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Sat May 22 05:25:20 2004]:

> With the attached patch the extra citizen can be always be placed and
> it is made general.

A good idea.  However I don't think the test is strong enough.  Lots of
places in the code assume that _elvises_ can be placed into any city. 
Later this may be generalized into a SP_DEFAULT value.  This default
value may be read from the ruleset or the first unrestricted specialist
can just be chosen.

But for the current code you must have min_size_elvis <= 1 or you get in
trouble.

jason



[Prev in Thread] Current Thread [Next in Thread]