Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] (PR#8690) unit display - hitpoints bug
Home

[Freeciv-Dev] (PR#8690) unit display - hitpoints bug

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: chrisk@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#8690) unit display - hitpoints bug
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 22 May 2004 23:15:45 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8690 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Sat May 22 12:04:19 2004]:

> At least this issue (not sure about the others mentioned in this
> thread) is caused by a blue border line. This overwrites the hitpoint
> display in the mapview.

Oh, duh.

So should units be drawn on top of the map grid and borders?  This is
already done in iso-view but I didn't think it was necessary to change
non-iso view to match.

The change is easy; this patch does it.  But I'm not sure if there will
be any bad effects.

jason

? convert.sh
? flags
? data/flags
Index: client/tilespec.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/tilespec.c,v
retrieving revision 1.170
diff -u -r1.170 tilespec.c
--- client/tilespec.c   22 May 2004 18:12:21 -0000      1.170
+++ client/tilespec.c   23 May 2004 06:15:28 -0000
@@ -2211,11 +2211,8 @@
     }
   }
 
-  if (is_isometric) {
-    /* Add grid.  In classic view this is done later. */
-    sprs->type = DRAWN_GRID;
-    sprs++;
-  }
+  sprs->type = DRAWN_GRID;
+  sprs++;
 
   /* City.  Some city sprites are drawn later. */
   if (pcity && draw_cities && !unit_only) {
@@ -2283,12 +2280,6 @@
     }
   }
 
-  if (!is_isometric) {
-    /* Add grid.  In iso-view this is done earlier. */
-    sprs->type = DRAWN_GRID;
-    sprs++;
-  }
-
   return sprs - save_sprs;
 }
 

[Prev in Thread] Current Thread [Next in Thread]