[Freeciv-Dev] Re: (PR#2521) general effects framework

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2521 >

here is version 9: (patchset attached as a comment to the ticket)

o new and improved surviving effects system. can_space and can_nuke
  are history. EFT_ANY_GOVERNMENT, EFT_CAPITAL_EXISTS, EFT_ENABLE_NUKE,
  EFT_ENABLE_SPACE, EFT_ENEMY_PEACEFUL, EFT_HAVE_EMBASSIES, EFT_NO_ANARCHY
  can all be surviving.
o fix a core crash from a spurious lines in packets.def
o fix a bug in ruleset loading code that caused an assert in
  contains_special()
o use new specvec code.
o added static void delete_effect_helper() (changed from macro)
o added a section in HACKING on effects code (still some to be written)
o added some notes in README.effects regarding cond_* and global effects.
o fixed a typo EFT_REVOLT_DIST_Pct -> EFT_REVOLT_DIST_PCT
o many other bugs.

ACHTUNG: I'm thinking very hard about killing off cond_eff. This means that
effects will not be able to depend on other effects to be active. This
reduces modding possibilities but also reduces much pain and suffering on
the part of developers. Speak up now or forever hold your peace.

-mike