[Freeciv-Dev] Re: (PR#8725) /take doesn't work from the client

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8725 >

On Wed, May 12, 2004 at 08:02:33PM -0700, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8725 >
> 
> James Canete wrote:
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=8725 >
> > 
> >>[jdorje - Wed May 12 21:29:11 2004]:
> >>
> >> From the client chatline, I can't "/take foo".  I must "/take myname 
> >>foo".  This is bad.
> > 
> > IIRC this is only if the client has hack.
> 
> Why would that make a difference?  Because only clients with hack can 
> use the two-parameter form?

yes. if you have hack, you can force other users to take other players.

> >  Perhaps /take should assume
> > myname if there is only one parameter?
> 
> For requests from the client, yes.

shouldn't be so bad. you just need to check that caller != NULL.
console should always have to pass two parameters.

-mike