[Freeciv-Dev] (PR#8647) Clarification on do_make_unit_veteran

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8647 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Sun May 02 09:04:15 2004]:
> 
> 
> Is it intended that with gen-effects effects can give a freshly built
> unit more than the first veteran level? If yes the docu of
> do_make_unit_veteran should be adjusted. If not the return type should
> be changed to bool.

The return type should be left as int, the documentation should be
fixed, and the function should be renamed to a non-boolean-centric name
(new_unit_veteran_level?).

jason