[Freeciv-Dev] Re: (PR#8648) Bool and type related cleanups

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8648 >

On Tue, May 04, 2004 at 10:32:19AM -0700, Jason Short wrote:
>      /* UDP can send duplicate or delayed packets. */
>      server_list_iterate(*lan_servers, aserver) {
> -      if (!mystrcasecmp(aserver->name, servername)
> -          && !mystrcasecmp(aserver->port, port)) {
> -        return lan_servers;
> -      }
> +      if (mystrcasecmp(aserver->name, servername) != 0
> +         && mystrcasecmp(aserver->port, port) == 0) {
> +       return lan_servers;
> +      }
>      } server_list_iterate_end;
>                                                                        
>         
>      freelog(LOG_DEBUG,
> 
> should both be != 0, yes?

Both should be == 0

> -      && !unit_list_get(&ptile->units, 0)->occupy) {
> +      && unit_list_get(&ptile->units, 0)->occupy) {
> 
> why?

Error on my part.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Just because you put a flag on the moon doesn't make it yours, it just
  puts a hole in the moon."