[Freeciv-Dev] (PR#8672) punit->occupy has no value at the server

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8672 >

Originally punit->client.occupy was created so the client could track if 
units were occupied.  It was a boolean.

It was changed to punit->occupy and turned into an integer.  I don't 
know why.  The server still doesn't use this value.

However the AI code has started using the value.  This won't work since 
it's always 0 at the server.

The quick fix is that the AI should call get_transporter_occupancy() 
instead.  However this function is slow.  Better would be to update the 
punit->occupy value at the server.  It should be renamed 
(punit->occupancy?) and updated in 
load_unit_onto_transporter/unload_unit_from_transporter.

jason