[Freeciv-Dev] Re: (PR#8647) Clarification on do_make_unit_veteran

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8647 >

On Sun, May 02, 2004 at 09:02:25AM -0700, Mike Kaufman wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8647 >
> 
> On Sun, May 02, 2004 at 02:04:16AM -0700, Raimar Falke wrote:
> > 
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=8647 >
> > 
> > 
> > Is it intended that with gen-effects effects can give a freshly built
> > unit more than the first veteran level? If yes the docu of
> > do_make_unit_veteran should be adjusted. If not the return type should
> > be changed to bool.
> 
> I don't know: what do you want to intend?
> 
> Right now we've got these:
> 
> "Unit_Vet_Combat" - chance of units of class .aff_unit becoming veteran
>                   after a successful combat becomes AMOUNT percent
> 
> "Unit_Veteran"  - all units of class .aff_unit produced are veteran
>                   units
> 
> 
> It does not appear that these were written for multiple veteran levels.
> We will have effect->value1 and effect->value2 in addition to effect->amount
> to make these changes...

I think you have to change gen-effect than. And the docu of
do_make_unit_veteran needs to be changed.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Python 2.0 beta 1 is now available [...]. There is a long list of new 
  features since Python 1.6, released earlier today. We don't plan on 
  any new releases in the next 24 hours."
    -- Jeremy Hylton at Slashdot